Changeset 1095

Timestamp:

Dec 30, 2017, 3:30:28 PM (7 years ago)

Author:

s10k

Message:

Small code refactoring

Location:

s10k/CommonUtils

Files:

• util.cpp (modified) (5 diffs)
• util.h (modified) (1 diff)

s10k/CommonUtils/util.cpp

@@ -69 +69 @@
     if (!dir.exists())
         return true;
-    foreach(const QFileInfo &info, dir.entryInfoList(QDir::Dirs | QDir::Files | QDir::NoDotAndDotDot)) {
+    for(const QFileInfo &info : dir.entryInfoList(QDir::Dirs | QDir::Files | QDir::NoDotAndDotDot)) {
         if (info.isDir()) {
             if (!rmDir(info.filePath()))
@@ -181 +181 @@
 }
 
-bool backupFile(QString file){
-    return QFile::copy(file,file+".bak");
+bool backupFile(const QString &file, QString newFilename){
+        
+        if(newFilename.isEmpty()){
+                newFilename = file;
+        }
+        
+    return QFile::copy(file, newFilename+".bak");
 }
 
@@ -334 +339 @@
 // Check if any string in the list is empty
 bool checkEmptySpaces(QStringList toCheck){
-    foreach (QString current, toCheck){
+    for (const QString &current : toCheck){
         if(current.trimmed().isEmpty()){
             return true; //There are empty spaces
@@ -343 +348 @@
 
 bool checkIfIntegers(QStringList toCheck){
-    foreach (QString current, toCheck){
+    for (const QString &current : toCheck){
         if(!isStringInteger(current)){
             return true; // Some aren't valid integers
@@ -352 +357 @@
 
 bool checkIfDoubles(QStringList toCheck){
-    foreach (QString current, toCheck){
+    for (const QString &current : toCheck){
         if(!isStringDouble(current)){
             return true; // Some aren't valid doubles

s10k/CommonUtils/util.h

@@ -65 +65 @@
 QString getAppPath();
 
-bool backupFile(QString file);
+bool backupFile(const QString &file, QString newFilename="");
 
 }