#14 closed defect (fixed)
AEI2 replaces Oni app and launch_args.txt
Reported by: | edt | Owned by: | Alloc |
---|---|---|---|
Priority: | major | Component: | AEI2 |
Keywords: | Cc: |
Description
I replaced the Intel Oni installed with AEI2 with a newer version and updated the launch_args.txt.
However, each time I launch AEI2 to install a mod, it replaces my newer version with the older one and overwrites my launch_args.txt.
Change History (8)
comment:1 Changed 11 years ago by Iritscen
comment:2 follow-up: ↓ 5 Changed 11 years ago by Alloc
Question is how to make sure the proper files are installed otherwise. Only check if the files within the core packages are existing at the destination and overwrite only on update to the core packages? Don't know if that's the best solution.
comment:3 Changed 11 years ago by Iritscen
I can't see any problems with that solution at the moment, seems good to me. If someone replaces a file manually with a newer ones, they probably know what they are doing and can take responsibility for any problems they might cause.
If you wanted to be super-careful you could do a checksum comparison or at least a timestamp comparison (checksum is better but obviously more disk-intensive) on each core tool file at launch and provide a passive warning if there is a mismatch ("passive" meaning something that's not a pop-up dialog; an out-of-the-way text message somewhere), or else at least log this mismatch, so if a user reports a problem and shows you his log, you can show him where he went wrong :-)
comment:4 Changed 11 years ago by Alloc
- Status changed from new to accepted
comment:5 in reply to: ↑ 2 ; follow-up: ↓ 6 Changed 11 years ago by Samer
I agree with Alloc .. what if someone replaces them with older files instead of newer .. a note : instead of replacing the Oni.exe in the main directory replace it in the \packages\00010Oni_game_app_.. folder and delete the one in the main directory .. then it won't be overwritten when you install because that package will have the timestap of the depot one but the content of whatever you placed and that will be automatically moved to the main directory .. that's how i tested older onisplit and dll. then simply made the installer redownload them when i wanted the depot version back. that will solve your problem Edt without requiring any change in the AEinstaller
comment:6 in reply to: ↑ 5 Changed 11 years ago by Alloc
Replying to Samer:
... instead of replacing the Oni.exe in the main directory replace it in the \packages\00010Oni_game_app_.. folder ...
That's true and I did it myself this way. Though I don't think that fiddling with packages themselves is even worse than replacing files manually as we won't even be able to notice that anymore. So if the user forgets to redownload afterwards this could lead to unexpected behaviour.
I think the idea to only replace files on updates and on startup of AEI do a checksum comparison of the files is quite good. This way the user can replace stuff if he wants to and we still can see "unauthorized" changes to core tool package files in reports.
comment:7 Changed 11 years ago by Alloc
- Resolution set to fixed
- Status changed from accepted to closed
In 2.02
Only overwrites files when updating a (core) package.
comment:8 Changed 11 years ago by alloc
In 804:
This is caused by the AEI re-installing the core tool packages on each startup. Is that a necessary feature, Alloc? Can we just, well, not do that? :-)