Opened 11 years ago
Closed 11 years ago
#74 closed enhancement (fixed)
Allow for "Patches" as section name
Reported by: | Christian | Owned by: | Christian |
---|---|---|---|
Priority: | major | Component: | Daodan/Win |
Keywords: | Cc: |
Description
Currently the patches section is called "Patch" (sing.) while options are within "Options" (pl.). As that is not really straightforward both "Patch" (for compatibility reasons) and "Patches" should be allowed.
Change History (3)
comment:1 by , 11 years ago
comment:2 by , 11 years ago
Actually, we know now that the Languages section was going to be used for localization; apparently the idea was that, since the Daodan was designed to patch the English Oni.exe, the Languages section would allow translation of English Oni.exe's strings into the language of whatever version of Oni.exe that it was replacing in someone's foreign-language Oni installation. See ticket #80.
I would suggest you can take this opportunity to reorganize the way the INI file lists all patches/options. As we discussed, Languages is not even needed, as "chinese" can be under Patches or Options and the rest of the language options are pointless. Next, it doesn't make a lot of sense to separate Options from Patches. The Options are border, nomultibyte, gamma, switch, topmost, and usedaodanbsl.
"nomultibyte" just redirects to a Patch by that name, "switch" seems pointless unless someone can explain why it's different than simply *not* using "noswitch", and "usedaodanbsl" sounds a lot like a Patch to me, as it requires hooking into Oni to add new commands. That leaves "topmost", "border", and "gamma", which are window hacks much like the Patches "alttab", "clipcursor", and "usedaodangl".
Any minor distinction internally between the nature of a "patch" and an "option" will be lost on the end user, so they can't be expected to remember which option goes under Patch or Options. If there's going to be any grouping into sections, it ought to be by type of effect, like "Window" containing all window hacks.